Skip to content

Unify "Hide download" for public share and "Allow download" behavior for user share + provide possibility to configure it #46256

Description

@Koc

I've just realized that there is some inconsistency between sharing for concrete user and public link.

🔍 Public share has "Hide download" checkbox

image

🔍 At the same time sharing for concrete user has inversed logic "Allow download"

image

It would be nice to unify behavior and provide same experience for both public and user shares for better consistency.
Also there is possibility to change default permission for a new share. But there is no way to disable download for new shared. Can we add this option?

image

Related to #45412.

Activity

  1. sorbaugh commented on Feb 19, 2025

    @sorbaugh
    Contributor

    @marcoambrosini clearing this up would allow us to know how to deal correctly with several bugs that are open at the moment. Can you check this from a design perspective which would be the way to go?

  2. jancborchardt commented on Mar 3, 2025

    @jancborchardt
    Member

    Indeed it makes sense to use the same wording for both. "Hide download" would make most sense because then none of the optional checkboxes are checked by default.

  3. susnux commented on Apr 3, 2025

    @susnux
    Contributor

    @jancborchardt it is not really only about the visual representation. The question we need to be answered by product design is:

    Should we keep offering two different functionalities.

    If yes:

    • Allow both for both sharing types?
    • Keep behavior of 30 and below of having "hide download" on public shares which still allows download but just hides the download button and "prevent download" on internal shares (no download at all - only online viewing in office apps).

    If no:

    • Which one to keep?

    From what we have on requests (see also internal ticket) it seems we need both variants for both sharing types.
    Or we just decide we do not want this and keep only one consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions