Repository navigation
Conversation
mejo-
force-pushed
the
fix/30278/files_first
branch
from
December 21, 2021 15:52
a8960d3 to
be35955
Compare
Member
Author
|
The unit tests I added ealier still succeed, but my manual tests (by opening documents in the viewer app or opening the sidebar in Files) now also succeed :) |
CarlSchwan
reviewed
Dec 21, 2021
mejo-
force-pushed
the
fix/30278/files_first
branch
from
December 21, 2021 15:57
be35955 to
1272144
Compare
juliusknorr
approved these changes
Dec 21, 2021
Member
Author
|
Closing this PR as there's agreement that it's the wrong approach. See the discussion in #30278 for further information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the scripts of many apps depend on the files scripts being
initialized first. So let's keep this for now and always load the files
scripts second (after core).