Skip to content

Move guest.css to scss - #33708

Merged
juliusknorr merged 3 commits into
masterfrom
enh/guest-scss
Dec 22, 2022
Merged

juliusknorr merged 3 commits into
masterfrom
enh/guest-scss

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Aug 26, 2022 •

Copy link
Copy Markdown
Member

Moving guest.css to SCSS to be able to reuse bits from server styling later on and make it possible to cleanup its code

Based on #33707

@juliusknorr juliusknorr added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Aug 26, 2022

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

am curious to find out where these animations are used...

@CarlSchwan CarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea

Base automatically changed from bugfix/update-container to master August 26, 2022 11:08
@PVince81

PVince81 commented Sep 1, 2022

Copy link
Copy Markdown
Member

conflicts

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorr merged commit ff2b8ca into master Dec 22, 2022
@juliusknorr
juliusknorr deleted the enh/guest-scss branch December 22, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants