Skip to content

[stable28] Support excalidraw file type - #46712

Merged
skjnldsv merged 3 commits into
stable28from
backport/45353/stable28
Jul 27, 2024
Merged

skjnldsv merged 3 commits into
stable28from
backport/45353/stable28

Conversation

@hweihwang

Copy link
Copy Markdown
Contributor

Backport of PR #45353 to stable28. Adds support for excalidraw file type, including mime type recognition and icon.

@hweihwang
hweihwang requested review from blizzz and juliusknorr July 24, 2024 08:31
@solracsf solracsf changed the title Backport: Support excalidraw file type (#45353) [stable28 ] Support excalidraw file type Jul 24, 2024
@solracsf solracsf changed the title [stable28 ] Support excalidraw file type [stable28] Support excalidraw file type Jul 24, 2024
@solracsf solracsf added the 3. to review Waiting for reviews label Jul 24, 2024
@solracsf solracsf added this to the Nextcloud 28.0.9 milestone Jul 24, 2024
Comment thread lib/private/Repair/RepairMimeTypes.php Outdated
Comment on lines +421 to +427
if (version_compare($mimeTypeVersion, '29.0.0.6', '<') && $this->introduceAacAudioType()) {
$out->info('Fixed aac mime type');
}

if (version_compare($mimeTypeVersion, '29.0.0.10', '<') && $this->introduceReStructuredTextFormatType()) {
$out->info('Fixed ReStructured Text mime type');
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can skip those in the backport.

Comment thread lib/private/Repair/RepairMimeTypes.php Outdated
Comment on lines +344 to +350
$serverVersion = $this->config->getSystemValueString('version', '0.0.0');
// 29.0.0.10 is the last version with a mimetype migration before it was moved to a separate version number
if (version_compare($serverVersion, '29.0.0.10', '>')) {
return $this->config->getAppValue('files', 'mimetype_version', '29.0.0.10');
}
return $this->config->getSystemValueString('version', '0.0.0');

return $serverVersion;