Skip to content

fix(setup): hide config section if autoconfig is valid - #56231

Merged
skjnldsv merged 1 commit into
masterfrom
skjnldsv-patch-1
Oct 1, 2026
Merged

skjnldsv merged 1 commit into
masterfrom
skjnldsv-patch-1

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Nov 6, 2025

Copy link
Copy Markdown
Member

Fix #56160

@skjnldsv skjnldsv added this to the Nextcloud 33 milestone Nov 6, 2025
@skjnldsv skjnldsv self-assigned this Nov 6, 2025
@skjnldsv
skjnldsv requested a review from a team as a code owner November 6, 2025 07:29
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels Nov 6, 2025
@skjnldsv
skjnldsv removed the request for review from a team November 6, 2025 07:29
@skjnldsv

This comment was marked as resolved.

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@scubamuc

scubamuc commented Nov 6, 2025

Copy link
Copy Markdown

@skjnldsv confirmed

@kra-mo

kra-mo commented Nov 7, 2025

Copy link
Copy Markdown
Member

No strong opinions on whether it should be done that way in the first place, but it seems like an improvement over the status quo.

But I'd wait for any disagreements to be voiced first.

@skjnldsv

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
@susnux

This comment was marked as resolved.

@skjnldsv

Copy link
Copy Markdown
Member Author

/compile rebase

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 30, 2026
@skjnldsv

skjnldsv commented Sep 30, 2026 •

Copy link
Copy Markdown
Member Author

/backport 93c72c6 to stable35

@skjnldsv

Copy link
Copy Markdown
Member Author

/backport 93c72c6 to stable34

Fix #56160

Assisted-by: ClaudeCode:claude-sonnet-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@skjnldsv
skjnldsv merged commit 64cbcb9 into master Oct 1, 2026
86 checks passed
@skjnldsv
skjnldsv deleted the skjnldsv-patch-1 branch October 1, 2026 09:37
@backportbot

backportbot Bot commented Oct 1, 2026

Copy link
Copy Markdown

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/56231/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93c72c6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56231/stable34

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Oct 1, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/56231/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93c72c6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56231/stable35

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv

skjnldsv commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

Gonna skip backports, this is for new instances anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish AI assisted backport-request bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

installer: database section now visible if auto-setup is used

10 participants