[stable34] fix(l10n): stop double-escaping the instance name in settings text - #64934
Merged
Merged
Conversation
susnux
approved these changes
Sep 30, 2026
AndyScherzinger
approved these changes
Oct 6, 2026
t() HTML-escapes placeholder values unless told otherwise. That is right
when the result is handed to v-html, and wrong for these six strings,
because every one of them is rendered as text - {{ }} interpolation,
NcSettingsSection's description, NcInputField's helperText, or an
aria-label. Vue escapes the string again on render, so the entity is what
the user actually reads: an instance called "Foo's Speicher" shows up as
"Foo's Speicher" in the OAuth 2.0 clients section and in four places
in the LDAP wizard.
Turning escaping off for these call sites is safe on two counts. The
results are text bindings, so Vue still escapes them exactly once on
render, and ThemingDefaults::getName() already runs the configured
instance name through strip_tags() before it reaches the theming
capability, so the value cannot carry markup to begin with.
This matches how the rest of the codebase handles text-rendered
placeholders, including the neighbouring user count in UsersTab.vue.
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Tor Valstrom <51440386+torvalstrom@users.noreply.github.com>
AndyScherzinger
force-pushed
the
backport/64369/stable34
branch
from
October 6, 2026 06:39
59ca0ff to
662e956
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #64369