Repository navigation
generateAuthorizationCode not being awaited #204
Description
generateAuthorizationCode is not being awaited and when I use the authorizationCode in my model it errors because its a promise and not a string, pr: #203
This is a very important issue to fix because if someone follows the types and implements the model correctly it just crashes and doesn't work at all
Workaround: await authorizationCode in the models saveAuthorizationCode function
Activity
jankapunkt commentedon Aug 2, 2023
Hi @MaximilianGaedig I can confirm your observation and thanks a lot for immediately opening a PR, too! I would like to investigate, why the tests never catched this one, before merging.
jankapunkt commentedon Aug 2, 2023
published in https://github.com/node-oauth/node-oauth2-server/releases/tag/v5.0.0-rc.1
MaximilianGaedig commentedon Aug 2, 2023
Thanks a lot for this quick handling of the issue/pr!