Skip to content

feat: enable async start/stop server #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knolleary merged 1 commit into from
Oct 28, 2024
Merged

feat: enable async start/stop server #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 47 additions & 29 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,37 +394,55 @@ class NodeTestHelper extends EventEmitter {
return request(this._httpAdmin);
}

startServer(done) {
this._app = express();
const server = stoppable(http.createServer((req, res) => {
this._app(req, res);
}), 0);

this._RED.init(server,{
logging:{console:{level:'off'}}
});
server.listen(this._listenPort, this._address);
server.on('listening', () => {
this._port = server.address().port;
// internal API
this._comms.start();
done();
});
this._server = server;
async startServer(done) {
try {
await new Promise((resolve, reject) => {
this._app = express();
const server = stoppable(
http.createServer((req, res) => this._app(req, res)),
0
);

this._RED.init(server, {
logging: { console: { level: 'off' } },
});

server.listen(this._listenPort, this._address);

server.on('listening', () => {
this._port = server.address().port;
this._comms.start();
this._server = server;
resolve();
});

server.on('error', reject);
});

if (done) done();
} catch (err) {
if (done) done(err);
else throw err;
}
}

//TODO consider saving TCP handshake/server reinit on start/stop/start sequences
stopServer(done) {
if (this._server) {
try {
// internal API
this._comms.stop();
this._server.stop(done);
} catch (e) {
done();

async stopServer(done) {
try {
if (this._server) {
await new Promise((resolve, reject) => {
this._comms.stop();

this._server.stop((err) => {
if (err) reject(err);
else resolve();
});
});
}
} else {
done();

if (done) done();
} catch (err) {
if (done) done(err);
else throw err;
}
}

Expand Down