Fish shell

[ghostdevv]

This doesn't seem to work for me using fish, I had to switch to bash. While this isn't a problem it would be nice to support it.

OS: Manjaro Linux
Fish: 3.2.1
Node: 12 (latest)
Node gui: Starter template

[shirakaba]

doesn't seem to work

In what way does it fail? Please provide details (e.g. CLI logs, error logs). Does it fail at build-time or run-time?

[ghostdevv]

Both build time and run time, I can try and get an error log for you both later tonight

[shirakaba]

Yes please! Otherwise I've got nothing to go on.

[ghostdevv]

Hey, sorry for the late response @shirakaba . Here is the output of npm run dev after following the instructions here: https://sourceb.in/Tf2EFw8sDW

This might be a problem with npm install in fish as it seems to take a shorter amount of time and prints a lot less in fish than bash, it might be that fish isn't running something or building it properly?

[ghostdevv]

Update: this definitely seems like a problem with npm install as I switched to bash and typed npm install and it worked. Not sure if this problem is caused by npm or nodegui

[shirakaba]

@ghostdevv thanks for the details. It looks like bundling failed because the @nodegui/svelte-nodegui node module hadn’t been installed. So the question is why it hadn’t been installed.

What happens when you do a fresh clone of the starter template (in Fish) and follow the instructions up to and including the run npm install step? Is there an error seen during installation?

[ghostdevv]

I think running npm install in fish is causing whatever the build process that should run to not run. When I run npm install in bash it's running fine

[shirakaba]

@ghostdevv I've just updated the starter template because the package-lock had a possible version mismatch with the package.json. If you could please try starting a project afresh from that, I'd be interested to know the outcome.

[shirakaba]

@ghostdevv Also, what version of Node are you using?

[ghostdevv]

I was doing some more debugging and I noticed when fish started it is defaulting to node 16.0.0 for some reason, it's supposed to be on 14.x, when typing fish then node -v again it goes back to 14.x which works. Very odd.

Seems to just be issues with node 16 then.

Very odd:

[ghostdevv]

This is odd, I managed to sort out the version issue using a port of nvm for fish and installing worked fine however I am still getting the error, here is a fresh copy in case it's different: https://sourceb.in/KYdP9NaeoV

The same error happens when running npm run dev in bash so it might still be a install issue?

Both bash and fish are showing the same node version so I tried to do a fresh install via bash and it did not work.

[shirakaba]

I'm (successfully) using Node v14.6.0 myself, so I think we're onto something. What npm version is referenced? I'm on npm v6.14.7.

The same error happens when running npm run dev in bash so it might still be a install issue?

The error in your paste indicates that both Webpack and ts-loader are failing to resolve @nodegui/svelte-nodegui, so it would seem that node_modules/@nodegui/svelte-nodegui is missing following your npm install. Is this the case? I wonder whether the require() algorithm changed in some way since Node v14. But seems unlikely... Is node_modules/@nodegui/svelte-nodegui genuinely missing in your project?

The key thing I do know that changed since npm v6 (which was contemporary with Node v14) is how peer dependencies are handled.

If you're using npm v7 or higher, you could try npm install --legacy-peer-deps instead of npm install to keep installation consistent. Or just install using npm v6.

Could you provide full logs of what happens following a fresh npm install in fish?

[ghostdevv]

I am on npm 6.14.13, here are logs from npm install in fish: https://sourceb.in/oNS5t4nR1E

That dir exists:

[ghostdevv]

I am not sure this is just fish, I just tried in only bash and it still can't find svelte-nodegui. Which is making me confused.

I tried just basic node gui and it worked fine so I think that rules out possible system requirement errors? (Works in both fish and bash)

[shirakaba]

I have a suspicion.

As far as I can see (I’m on my phone), the @nodegui/svelte-nodegui/package.json lacks a main field.

The Rollup bundle I believe is outputting to dist/index.js:

svelte-nodegui/rollup.config.js

Line 55 in 1ce01eb

file: "dist/index.js",

Could you try manually patching that package.json to set the main field as such, then running npm run dev?