Removing FIPS CI in upgrading OpenSSL-1.1.0 #1191

Activity

1. gibfahn commented on Mar 26, 2018

   

   gibfahn

   on Mar 26, 2018

   Member

   More actions

   We should be able to just skip the job if the openssl version is 1.1.0.
2. mhdawson commented on Mar 29, 2018

   

   mhdawson

   on Mar 29, 2018

   Member

   More actions

   Agree with @gibfahn that we should add a check for the openssl version and skip if it is 1.1.X so that we still have testing for older versions.
3. shigeki commented on Mar 30, 2018

   

   shigeki

   on Mar 30, 2018

   Author

   More actions

   Please let me know what is needed to check the openssl version in CI before building.
   I've just made configure with checking its options and exit it as

     if options.openssl_fips:
        print('Error: FIPS is not supported yet in this version')
        exit(1)
   

   in
   https://github.com/shigeki/node/blob/9beb31e1f125a1a623be2bcef19dbb425fc3c5f0/configure#L1091-L1093.
4. rvagg commented on Mar 30, 2018

   

   rvagg

   on Mar 30, 2018

   Member

   More actions

   We have a bunch of version exclusions in node-test-commit-linux-containered already. I've added the following to the fips test which so far doesn't have any:

   MAJOR_VERSION=`cat src/node_version.h | grep "#define NODE_MAJOR_VERSION" | awk '{ print $3}'`
   RUN_TESTS="RUN"
   if [[ ${MAJOR_VERSION} -gt 9 ]]; then
     SKIP_MESSAGE="Not valid for Node versions greater than 9"
     echo $SKIP_MESSAGE
     echo "1..1" >${WORKSPACE}/test.tap
     echo "ok 1 $SKIP_MESSAGE" >>${WORKSPACE}/test.tap
     exit 0
   fi

   Also @MylesBorins FYI I raised the --without-intl test runner to >=9 earlier this week so we shouldn't get the v8 failures anymore.
5. rvagg

   closed this as completedon Mar 30, 2018