Repository navigation
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
s/vinil/vinyl Do we have tests to prove it is no longer flaky? |
Member
|
If this is the problem we talked about @MylesBorins, it was solved in gulpjs/vinyl-fs#296. |
Contributor
|
It has been flaky on various versions before that problem was fixed. So
just would like to ensure this is fixed on 4 / 6 / 8 / 9 / master before
removing flaky
…On Tue, Feb 27, 2018, 9:42 AM Matteo Collina ***@***.***> wrote:
If this is the problem we talked about @MylesBorins
<https://github.com/mylesborins>, it was solved in gulpjs/vinyl-fs#296
<gulpjs/vinyl-fs#296>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#550 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV-mMCOE-SbaYxm8HfQ4_BFyHUMZzks5tZBRRgaJpZM4SU-1E>
.
|
Contributor
Author
|
Seems like it's still fails across all the platforms: 10:22:02 error: | 223 passing (25s)
10:22:02 error: | 18 pending
10:22:02 error: | 1 failing
10:22:02 error: |
10:22:02 error: | 1) .dest() with custom owner calls fchown when the uid and/or gid are provided on the vinyl stat:
10:22:02 error: |
10:22:02 error: | Uncaught Error: Expected 0 to equal 1
10:22:02 error: | + expected - actual
10:22:02 error: |
10:22:02 error: | -0
10:22:02 error: | +1
10:22:02 error: |
10:22:02 error: | at assert (node_modules/expect/lib/assert.js:29:9)
10:22:02 error: | at Expectation.toEqual (node_modules/expect/lib/Expectation.js:81:30)
10:22:02 error: | at assert (test/dest-owner.js:49:38)
10:22:02 error: | at ConcatStream.<anonymous> (node_modules/concat-stream/index.js:36:43)
10:22:02 error: | at finishMaybe (node_modules/readable-stream/lib/_stream_writable.js:620:14)
10:22:02 error: | at endWritable (node_modules/readable-stream/lib/_stream_writable.js:628:3)
10:22:02 error: | at ConcatStream.Writable.end (node_modules/readable-stream/lib/_stream_writable.js:584:41)
10:22:02 error: | at Pumpify.onend (node_modules/readable-stream/lib/_stream_readable.js:577:10)
10:22:02 error: | at endReadableNT (node_modules/readable-stream/lib/_stream_readable.js:1000:12)
10:22:02 error: | at _combinedTickCallback (internal/process/next_tick.js:80:11)
10:22:02 error: | at process._tickCallback (internal/process/next_tick.js:104:9)
10:22:02 error: |
10:22:02 error: |
10:22:02 error: |
10:22:02 error: |
10:22:02 error: | npm ERR! Test failed. See above for more details.
10:22:02 error: done | The smoke test has failed.This will be investigated in #537. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #537
Checklist
npm testpasses