Skip to content
This repository was archived by the owner on Aug 1, 2019. It is now read-only.

Create weekly-update.2015-04-03.md - #52

Merged
yosuke-furukawa merged 5 commits into
nodejs:masterfrom
Gioyik:patch-1
Apr 4, 2015
Merged

yosuke-furukawa merged 5 commits into
nodejs:masterfrom
Gioyik:patch-1

Conversation

@Gioyik

@Gioyik Gioyik commented Apr 3, 2015

Copy link
Copy Markdown
Contributor

No description provided.

This comment was marked as off-topic.

@Gioyik

Gioyik commented Apr 4, 2015

Copy link
Copy Markdown
Contributor Author

Changes requested by @yosuke-furukawa are done. Let me know if there's something to change/add.

This comment was marked as off-topic.

@yosuke-furukawa

Copy link
Copy Markdown
Member

I will merge if you add the news.

@Gioyik

Gioyik commented Apr 4, 2015

Copy link
Copy Markdown
Contributor Author

@yosuke-furukawa done :)

@diagramatics

Copy link
Copy Markdown
Contributor

Formatting nitpicking. Community updates and upcoming events should be on heading level 3 as well as the title.

@Gioyik

Gioyik commented Apr 4, 2015

Copy link
Copy Markdown
Contributor Author

@diagramatics I created this using the template used before for weekly updates:

https://github.com/iojs/evangelism/blob/master/weekly-updates/weekly-update.2015-03-20.md

@diagramatics

Copy link
Copy Markdown
Contributor

It should be on level 3 for easier copy and paste to Medium's editor without having to reformat the text again. I mentioned about this earlier but it seems the change was only made in the Medium posts and not in the Markdown files as well.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@Gioyik

Gioyik commented Apr 4, 2015

Copy link
Copy Markdown
Contributor Author

All suggested changes are done. Feel free to do a double check to see if this is ok to merge (let me know if you want this PR squashed).

I want to discuss something. Should we change in past weekly updates from h1 to h3 titles? or just keep them in that form because are already published?

Thanks

@yosuke-furukawa

Copy link
Copy Markdown
Member

Should we change in past weekly updates from h1 to h3 titles?

I don't have strong opinion... I vote for keep the style, those update are already published.

@yosuke-furukawa

Copy link
Copy Markdown
Member

LGTM

yosuke-furukawa added a commit that referenced this pull request Apr 4, 2015
Create weekly-update.2015-04-03.md
@yosuke-furukawa
yosuke-furukawa merged commit 859065f into nodejs:master Apr 4, 2015
@yosuke-furukawa

Copy link
Copy Markdown
Member

@iojs/evangelism please publish our weekly updates on medium.

@diagramatics

Copy link
Copy Markdown
Contributor

The published version has its heading levels changed already before posted on Medium. It's just that the Markdown files weren't updated to match the new formatting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants