Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Enormous footer on API site #189

Closed
Closed

Description

@bnb

I just went poking around, and I noticed this enormous footer on the docs site:

bigfooter

That's Firefox, but it's the same on Chrome. Is there a reason for this?

Activity

  1. Fishrock123 commented on Feb 13, 2015

    @Fishrock123
    Contributor

    Docs styles and content are still in the main repo. :)

    Looks like it was an oversight when @chrisdickinson was re-styling the docs for io.js, I think joyent has stuff down their in the node docs.

    The relavent lines are https://github.com/iojs/io.js/blob/v1.x/doc/api_assets/style.css#L394-L399 -- I'd gladly take a PR to make it like only 20px or something.

  2. bnb commented on Feb 13, 2015

    @bnb
    Author

    +1 for a PR to fix. Will this WG be inheriting the docs at some point? I was also going to raise an issue about how we'd need to be able to style them consistently with a redesign, but figured that would be automatic since they were part of this WG's repo--turns out I was wrong.

  3. Fishrock123 commented on Feb 13, 2015

    @Fishrock123
    Contributor

    Yeah. See nodejs/node#727

  4. chrisdickinson commented on Feb 13, 2015

    @chrisdickinson

    Ah, the footer was a bit of a rush job. Eventually site navigation was to go there.

  5. bnb commented on Feb 13, 2015

    @bnb
    Author

    @chrisdickinson Ah, okay.

  6. snostorm commented on Feb 23, 2015

    @snostorm
    Contributor

    Seems to have been merged upstream. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions