Skip to content

Update make-fetch-happen #2756

Closed
Closed

Description

@rtritto

make-fetch-happen dependency needs an update to v11 because @npmcli/move-file (dependency of cacache) is deprecated.

Steps to reproduce

  • yarn init -y
  • yarn set version canary
  • yarn add node-gyp@9.3.0
Output
➤ YN0000: ┌ Resolution step
➤ YN0061: │ @npmcli/move-file@npm:2.0.1 is deprecated: This functionality has been moved to @npmcli/fs
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed
➤ YN0000: Done with warnings

Activity

  1. cclauss commented on Nov 4, 2022

    @cclauss
    Contributor
  2. jonz94 commented on Nov 10, 2022

    @jonz94

    One thing to consider is that make-fetch-happen@^11 is only compatible with the following semver range for node: ^14.17.0 || ^16.13.0 || >=18.0.0 (source: https://github.com/npm/make-fetch-happen/releases/tag/v11.0.0)

    Updating make-fetch-happen to v11 will introduce breaking change since node-gyp@^9 still support node12:

    node-gyp/package.json

    Lines 36 to 38 in 2cc72be

    "engines": {
    "node": "^12.22 || ^14.13 || >=16"
    },

  3. rtritto commented on Nov 10, 2022

    @rtritto
    Author

    Node v12 reached end of support (is not maintained) and is deprecated.
    Node v18 can be added.

  4. added a commit that references this issue on Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions