Skip to content

Proposal: Authorise @Fishrock123 to create releases #1225

Closed

Description

@rvagg

@iojs/tc (and anyone else interested in commenting of course)

This is separate the question of Jeremiah on the TC. I actually intended to do this before he was even nominated to the TC by @mikeal simply because it'd be nice to have a broader group of releasers and neat to have someone not on the TC able to do this.

Currently there's myself and @chrisdickinson who are authorized to make releases. This authorization is both organisational (should have sign-off from the TC) and technical (needs GPG key on the README and ssh access to the website for the "dist" user).

We need more people able to make releases so we continue our cadence and not create bottlenecks or have a low bus-factor.

See https://github.com/iojs/io.js/blob/v1.x/doc/releases.md for how the release process works.

Activity

  1. chrisdickinson commented on Mar 21, 2015

    @chrisdickinson
    Contributor

    I am +1 on this.

  2. benjamingr commented on Mar 21, 2015

    @benjamingr
    Member

    Sure, sounds good :)

  3. bnoordhuis commented on Mar 21, 2015

    @bnoordhuis
    Member

    No disagreement from me.

  4. trevnorris commented on Mar 23, 2015

    @trevnorris
    Contributor

    cool

  5. added
    metaIssues and PRs related to the general management of the project.
    on Mar 24, 2015
  6. piscisaureus commented on Mar 25, 2015

    @piscisaureus
    Contributor

    Since there is no tc meeting this week: +1 from me

  7. Fishrock123 commented on Apr 1, 2015

    @Fishrock123
    Contributor

    fwiw I'm willing for this. :)

  8. bnoordhuis commented on Apr 1, 2015

    @bnoordhuis
    Member

    Unanimously +1'd in today's TC meeting. I'll close the issue but feel free to reopen if it needs to stay open.

  9. rvagg commented on Apr 1, 2015

    @rvagg
    MemberAuthor

    @Fishrock123 can you read https://github.com/iojs/io.js/blob/v1.x/doc/releases.md and then do the following:

    1. PR against README.md to add a PGP key fingerprint next to your name, make sure it's published and available as the doc says
    2. Tell me which is your primary SSH key @ https://github.com/Fishrock123.keys and I'll add that on the server and then you'll be set to go
  10. Fishrock123 commented on Apr 2, 2015

    @Fishrock123
    Contributor

    Sure, I'll get this sorted out tomorrow.

  11. Fishrock123 commented on Apr 2, 2015

    @Fishrock123
    Contributor

    I still need to sort out the SSH thing.

    Turns out I haven't used any of the github SSH keys in quite some time; I've been using github's personal access tokens through credential.helper=osxkeychain.

  12. Fishrock123 commented on Apr 2, 2015

    @Fishrock123
    Contributor

    Does it need to be accessible at https://github.com/Fishrock123.keys?

  13. Fishrock123 commented on Apr 2, 2015

    @Fishrock123
    Contributor

    Also, the thing I upload to the sks keyserver for the gpg key should be this, right?

    -----BEGIN PGP PUBLIC KEY BLOCK-----
    Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
    Comment: GPGTools - https://gpgtools.org
    
    <snip>
    
    -----END PGP PUBLIC KEY BLOCK-----
    
  14. bnoordhuis commented on Apr 2, 2015

    @bnoordhuis
    Member

    Yes, it should be your public key.

  15. rvagg commented on Apr 3, 2015

    @rvagg
    MemberAuthor

    @Fishrock123 re ssh key, just get me your pubkey somehow, if you don't want it on github then perhaps email it to me and sign it with your gpg key that's in the pool, or something

  16. Fishrock123 commented on Apr 4, 2015

    @Fishrock123
    Contributor

    @rvagg it's the last (bottom) one on github now, ending in fImqwZn6NB

  17. rvagg commented on Apr 4, 2015

    @rvagg
    MemberAuthor

    done, you should be able to tools/release.sh when your keys is on the README and it should look something like this:

    $ tools/release.sh 
    # Selecting GPG key ...
    Using GPG key: 7D83545D
      Fingerprint: DD8F2338BAE7501E3DD5AC78C273792F7D83545D
    
    # Checking for releases ...
    No releases to promote!
    
  18. added a commit that references this issue on Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    metaIssues and PRs related to the general management of the project.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions