http2 callbacks silently allow exceptions

[grantila]

• Version: 8.4-8.7
• Subsystem: http2

When throwing an exception in a callback handler (e.g. in response), http2 silently does nothing, except it emits streamClosed with an errorCode of NGHTTP2_NO_ERROR.

Expected behaviour; if I throw at http2, log to stderr, then kill the process

[jasnell]

Well that's not good is it :-) ... will investigate!
/cc @mcollina @apapirovski

[apapirovski]

Hmmmm... I can't seem to replicate this. Can you post some sample code?

[grantila]

Ugh, this happened when running unit tests with mocha, I never did a simple standalone test, although I obviously should have.

After having investigated a bit now, I realize that mocha sets an 'uncaughtException' handler which swallows the error and continues execution (contrary to what the Node.js documentation tells you to do). By removing all 'uncaughtException' handlers when running the same test within mocha, I get the correct behavior; stderr + process exit.

Since this is a mocha issue and not http2 (or Node.js for that mattter), I'll close this issue. Sorry for wasting your time 😔