Repository navigation
Why do you bind ”this“ in event handler #26711
Description
Activity
Why do you bind ”this“ here?
Mostly because it’s often useful, I assume – it means you don’t have to store the object in another way, and often you can avoid having a closure this way.
It is not compatible with browser.
Node’s
EventEmitterAPI doesn’t match the browser’sEventTargetAPI in a number of ways – that’s unfortunate, but it’s not something we could reasonably change easily.I’d say there’s a chance that
EventTargetcould be introduced into Node as it adopts more and more Browser APIs, but too much code relies on how the currentEventEmitterAPI works for us to make changes to that.Reacted by Alex Yang and Wang Jianhuiit’s a best way when you extend
EventEmitterjust to clarify, events emitted by EventTarget also bind
thisto the target, so there's not actually any difference here.Seems like not an issue? Closing...
I’d say there’s a chance that
EventTargetcould be introduced into NodeWould really like to see EventEmitter etc being implemented in node too so that ppl building cross browser/platform works the same way without any additional dependencies
node/lib/events.js
Line 198 in 2f9c9ee
Why do you bind ”this“ here?It is not compatible with browser.