Skip to content

Revert #1342 - #1349

Closed
Gioyik wants to merge 1 commit into
nodejs:v1.xfrom
Gioyik:patch-1
Closed

Revert #1342#1349
Gioyik wants to merge 1 commit into
nodejs:v1.xfrom
Gioyik:patch-1

Conversation

@Gioyik

@Gioyik Gioyik commented Apr 5, 2015

Copy link
Copy Markdown
Contributor

See discussion here: #1342

@mscdex mscdex added the doc Issues and PRs related to Node.js documentation. label Apr 5, 2015
@mscdex

mscdex commented Apr 5, 2015

Copy link
Copy Markdown
Contributor

The first line of the commit message should be prefixed with doc:

EDIT: actually I suppose something like this would be better: Revert "doc: fix typo in CHANGELOG.md" with a link to the commit on the proceeding commit message lines.

Fishrock123 pushed a commit that referenced this pull request Apr 5, 2015
@Gioyik @Fishrock123
Revert "doc: fix typo in CHANGELOG.md"
48d69cf 
This reverts commit bde2b3e.

PR-URL: #1349
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123

Fishrock123 commented Apr 5, 2015

Copy link
Copy Markdown
Contributor

_sigh_

Landed 48d69cf - thanks.

@Fishrock123 Fishrock123 closed this Apr 5, 2015
@Gioyik

Gioyik commented Apr 5, 2015

Copy link
Copy Markdown
Contributor Author

Thanks for the comments @mscdex and thanks for the merge @Fishrock123

@Fishrock123 Fishrock123 mentioned this pull request Apr 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gioyik @mscdex @Fishrock123