Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63641 +/- ##
==========================================
- Coverage 90.29% 90.26% -0.03%
==========================================
Files 790 789 -1
Lines 271689 271571 -118
Branches 51856 51837 -19
==========================================
- Hits 245312 245124 -188
- Misses 16878 16945 +67
- Partials 9499 9502 +3
🚀 New features to boost your workflow:
|
Flarna
reviewed
Jun 2, 2026
| als.run('test-context-1', common.mustCall(() => { | ||
| finished(readable, common.mustCall(() => { | ||
| assert.strictEqual(AsyncContextFrame.enabled || enabledHooksExist(), true); | ||
| assert.strictEqual(!!AsyncContextFrame.current() || enabledHooksExist(), true); |
Member
There was a problem hiding this comment.
I think this line can be removed together with const { enabledHooksExist } = require('internal/async_hooks');.
Member
Author
There was a problem hiding this comment.
Done, removed together with the now-unused imports and the --expose-internals flag.
mcollina
force-pushed
the
remove-async-hooks-als
branch
from
August 23, 2026 06:48
7972ebb to
23b757b
Compare
mcollina
force-pushed
the
remove-async-hooks-als
branch
from
September 19, 2026 06:20
23b757b to
777881d
Compare
Remove the async_hooks-based AsyncLocalStorage fallback and the --no-async-context-frame flag, making AsyncContextFrame the sole implementation. Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
remove-async-hooks-als
branch
from
September 19, 2026 07:19
777881d to
d144ec8
Compare
jasnell
approved these changes
Sep 19, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the async_hooks-based
AsyncLocalStoragefallback and the--no-async-context-frameflag, makingAsyncContextFramethe sole implementation.