Skip to content

test: verify fields in spawn{Sync} errors - #838

Closed
cjihrig wants to merge 1 commit into
nodejs:v1.xfrom
cjihrig:test
Closed

cjihrig wants to merge 1 commit into
nodejs:v1.xfrom
cjihrig:test

Conversation

@cjihrig

@cjihrig cjihrig commented Feb 13, 2015

Copy link
Copy Markdown
Contributor

This commit validates the properties of ENOENT error objects returned by spawn() and spawnSync(). This represents the tests requested in #721.

R=@rvagg

This commit validates the properties of ENOENT error objects
returned by spawn() and spawnSync().
@bnoordhuis

Copy link
Copy Markdown
Member

LGTM

@rvagg

rvagg commented Feb 13, 2015

Copy link
Copy Markdown
Member

lgtm

/cc @trevnorris @remixz

thanks Colin!

@remixz

remixz commented Feb 13, 2015

Copy link
Copy Markdown
Contributor

👍 Thanks!

cjihrig added a commit that referenced this pull request Feb 14, 2015
This commit validates the properties of ENOENT error objects
returned by spawn() and spawnSync().

PR-URL: #838
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
@cjihrig

cjihrig commented Feb 14, 2015

Copy link
Copy Markdown
Contributor Author

Landed in d53b636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants