Skip to content

deps: update libuv to 1.4.1 - #940

Closed
bnoordhuis wants to merge 1 commit into
nodejs:v1.xfrom
bnoordhuis:upgrade-libuv
Closed

bnoordhuis wants to merge 1 commit into
nodejs:v1.xfrom
bnoordhuis:upgrade-libuv

Conversation

@bnoordhuis

Copy link
Copy Markdown
Member

R=@indutny, /cc @rvagg

@indutny

indutny commented Feb 24, 2015

Copy link
Copy Markdown
Member

LGTM if CI is happy.

@rvagg

rvagg commented Feb 24, 2015

Copy link
Copy Markdown
Member

lgtm

@bnoordhuis

Copy link
Copy Markdown
Member Author

RE: CI, there are two runs in progress at the moment. I'm waiting for them to complete before I start testing this one.

@rvagg

rvagg commented Feb 24, 2015

Copy link
Copy Markdown
Member

@bnoordhuis just queue it up even if there are runs in play, many of the targets have multiple slaves to make it workable and they'll queue in any case but you'll still have the number / url

@bnoordhuis

Copy link
Copy Markdown
Member Author

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/192/ - I've had concurrent runs interact poorly with each other in the past (e.g. hitting the system-wide file descriptor limit) but let's hope for the best.

bnoordhuis added a commit that referenced this pull request Feb 25, 2015
PR-URL: #940
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg

rvagg commented Feb 25, 2015

Copy link
Copy Markdown
Member

landed @ 739fda1

@rvagg rvagg closed this Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants