Repository navigation
process-nextick-args used incorrectly #323
Description
process-nextick-args was modified to make the nextTick property a "live" binding. In 41a3301#diff-279988bef5e6fbf7ed82cae28ecc2d59L128 this was changed to keep a reference to a potentially stale function. I'm not sure how to go about changing the generated code to make this change, else I would just make a PR.
Activity
mcollina commentedon Mar 2, 2018
You need to fix it in this block: https://github.com/nodejs/readable-stream/blob/master/build/files.js#L127-L136.
Then
cd build; npm i; node build.js 8.9.4. Should do the trick.If you could also add a test, it would be awesome. Place it under https://github.com/nodejs/readable-stream/tree/master/test/ours.
mcollina commentedon Mar 3, 2018
Fixed in 2.3.5