Skip to content

fix undefined global for browser / service worker (v2.x branch) - #499

Merged
mcollina merged 1 commit into
nodejs:v2.xfrom
smeng9:v2.x
Feb 23, 2023
Merged

mcollina merged 1 commit into
nodejs:v2.xfrom
smeng9:v2.x

Conversation

@smeng9

@smeng9 smeng9 commented Nov 21, 2022

Copy link
Copy Markdown

@mcollina

Supersedes #493

Still need a v3.x branch to target at

@smeng9

smeng9 commented Nov 30, 2022

Copy link
Copy Markdown
Author

Any updates?

@smeng9

smeng9 commented Dec 12, 2022

Copy link
Copy Markdown
Author

@mcollina Bump

@mcollina

Copy link
Copy Markdown
Member

I'm currently swamped. I'll get to this as soon as I have time.

@mcollina

mcollina commented Jan 1, 2023

Copy link
Copy Markdown
Member

I've created the v3.x branch. Could you send a PR there too?

@smeng9

smeng9 commented Jan 3, 2023

Copy link
Copy Markdown
Author

Sure!

@smeng9

smeng9 commented Feb 20, 2023

Copy link
Copy Markdown
Author

Hi @mcollina,

Considering that 97.89% of downloads of readable-stream on npmjs still uses the pre 4.x version. Is it possible to get the fix for older versions merged soon as the adoption rate is slow for a major update.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants