Repository navigation
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Aviv Keller <me@aviv.sh>
Clarified the scope and access rights of the Node.js Doc Kit Team.
| | Repository | Everyone | @nodejs/web | @nodejs/nodejs-website | @nodejs/doc-kit | @nodejs/web-infra | @nodejs/web-admins | Notes | | ||
| | ---------------------------------------- | -------- | ----------- | ---------------------- | --------------- | ----------------- | ------------------ | ----------------------------------------------------------------------------------------------------------- | | ||
| | **[nodejs/discord-status-worker][]** | Read | - | - | - | Maintain | Admin | | | ||
| | **[nodejs/doc-kit][]** | Read | - | Write | Maintain | Maintain | Admin | | |
There was a problem hiding this comment.
I was wondering if they should be maintain on doc-kit and maybe write on nodejs.org/learn as they're downstream consumers of doc-kit. But also completely fine if they only get write on doc-kit and nothing else.
There was a problem hiding this comment.
i feel strongly that a new member should not be able to add another new person day one
There was a problem hiding this comment.
what? maintain doesn't give you permissions to add people.
There was a problem hiding this comment.
re-reading https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/managing-repository-roles/repository-roles-for-an-organization#permissions-for-each-role - i was mistaken. looking at all those permissions, maintain is still too high to me and this would be incongruent with our model for the website itself
edit: screenshot showing my perceived disconnect
There was a problem hiding this comment.
All good! I was just confused and wanted to ensure we're talking about the same thing
There was a problem hiding this comment.
your point about learn is a good one to consider. without write we'd expect them to fork and pr. i guess it depends on what we expect a doc-kit maintainer to do day to day. that's how they'd have to interact with core.... so maybe its fine
There was a problem hiding this comment.
looking at all those permissions, maintain is still too high to me and this would be incongruent with our model for the website itself
Yeah, that's fair. Although, the idea behind here is different. Because doc-kit team is a team dedicated to maintain the doc-kit project, including its packages. Whereas the Website Team is responsible for writing the website, but the maintainership of the website is part of the Web Infra team.
I guess we can leave with Write permissions, or solidify so that Website team has maintain on the Website, and doc-kit team has Maintain on doc-kit.
your point about learn is a good one to consider. without write we'd expect them to fork and pr. i guess it depends on what we expect a doc-kit maintainer to do day to day. that's how they'd have to interact with core.... so maybe its fine
The thing is that the UI components doc-kit uses are on the Website repo, so unsure if doc-kit team would need write on website. I guess for learn all they'd do there would be to update doc-kit packages... But I believe dependabot already does that so they don't really need Write permissions there.
TL;DR
- Write on Website, None on Learn, Write on Doc-Kit
Co-authored-by: Aviv Keller <me@aviv.sh>
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>


We created the @nodejs/doc-kit team on GitHub so contributors to nodejs/doc-kit can be onboarded without handing them the whole Web Team surface, and the docs here never caught up. This PR documents it:
PERMISSIONS.md: new@nodejs/doc-kitcolumn. The only non-empty cell isWriteon nodejs/doc-kit, everything else, including every external service, is-GOVERNANCE.md: new section covering the team, its scope, and its nomination process, which mirrors @nodejs/web-infraMEMBERS.md: new section, seeded with the current members of the GitHub teamonboarding/doc-kit.md: onboarding checklist, deliberately much shorter than web-infra'sREADME.md: two subteams becomes threeThe scope is intentionally narrow:
Writeon nodejs/doc-kit and nothing else. No publishing access for now, so no 1Password vault, no Vercel, no npm scope ownership, those stay with @nodejs/web-infra. Releases still go out through the repo's automated workflow via npm trusted publishing, so this doesn't block anyone from cutting one.Heads up that touching
GOVERNANCE.mdpulls in @nodejs/tsc via CODEOWNERS. Happy to split that file into its own PR if y'all would rather land the rest first.Refs: nodejs/admin#1091