Skip to content

Salt 3008 migration - #643

Merged
RobHooper merged 20 commits into
mainfrom
salt3008
Sep 18, 2026
Merged

Salt 3008 migration#643
RobHooper merged 20 commits into
mainfrom
salt3008

Conversation

@RobHooper

@RobHooper RobHooper commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Resolves #491

@RobHooper RobHooper self-assigned this Aug 21, 2026
RobHooper
RobHooper commented Aug 21, 2026
View reviewed changes
Comment thread salt/apache/init.sls Resolved
RobHooper
RobHooper commented Aug 21, 2026
View reviewed changes
Comment thread salt/core/init.sls Resolved
RobHooper
RobHooper commented Aug 21, 2026
View reviewed changes
Comment thread salt/core/init.sls Resolved
@RobHooper

RobHooper commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Todo before review + deployment:

  • Replace webutil
  • Test deployment with data before applying to live servers (deploying after database is already made etc)

RobHooper
RobHooper commented Aug 27, 2026
View reviewed changes
Comment thread salt/core/swap.sls Resolved
RobHooper
RobHooper commented Sep 11, 2026
View reviewed changes
Comment thread salt/mysql/init.sls Resolved
RobHooper
RobHooper commented Sep 11, 2026
View reviewed changes
Comment thread salt/php-fpm/init.sls Resolved
RobHooper
RobHooper commented Sep 11, 2026
View reviewed changes
Comment thread salt/python/extensions.sls Resolved
@RobHooper

RobHooper commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Noted bugs from testing:

  • grub-pc fails to patch without an active terminal (it prompts for which devices to install Grub on).

    • Considering patching by hand as part of "Create a server" guide. Or adding as a note.
    • This causes an error message "dpkg error code (1)" on all further states installing packages.

  • Local system Salt error, unable to find pillar / data for server on first run.

    • Look for a "refresh" command, or note in "Create a server"

jpmckinney added a commit that referenced this pull request Sep 11, 2026
@jpmckinney
chore: PR review #643
a33d297
jpmckinney
jpmckinney approved these changes Sep 11, 2026
View reviewed changes
Comment thread salt/core/init.sls Resolved
@jpmckinney

jpmckinney commented Sep 16, 2026

Copy link
Copy Markdown
Member

Let's squash when merging.

@RobHooper
RobHooper enabled auto-merge (squash) September 18, 2026 07:47
@RobHooper
RobHooper disabled auto-merge September 18, 2026 08:17
@RobHooper
RobHooper merged commit 6604801 into main Sep 18, 2026
13 checks passed
@RobHooper
RobHooper deleted the salt3008 branch September 18, 2026 08:42
@RobHooper RobHooper mentioned this pull request Sep 18, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees

@RobHooper RobHooper

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Salt 3008 migration

2 participants

@RobHooper @jpmckinney