Skip to content

[TEST] CMake component install test for resource_detectors - #3940

Merged
marcalff merged 3 commits into
open-telemetry:mainfrom
dbarker:test_resource_detectors_install
Mar 18, 2026
Merged

marcalff merged 3 commits into
open-telemetry:mainfrom
dbarker:test_resource_detectors_install

Conversation

@dbarker

@dbarker dbarker commented Mar 18, 2026 •

Copy link
Copy Markdown
Member

Tests install of the resource_detectors CMake component

Changes

  • Move resource_detectors .cc files to a src directory
  • Adds CMake install test
  • Updates docs to include the component

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov

codecov Bot commented Mar 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (fb8ae6d) to head (c345247).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3940   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         226      226           
  Lines        7229     7229           
=======================================
  Hits         6510     6510           
  Misses        719      719           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker
dbarker marked this pull request as ready for review March 18, 2026 13:19
@dbarker
dbarker requested a review from a team as a code owner March 18, 2026 13:19

@marcalff marcalff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff
marcalff merged commit 02a157a into open-telemetry:main Mar 18, 2026
123 of 125 checks passed
@dbarker
dbarker deleted the test_resource_detectors_install branch April 7, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants