Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4253 +/- ##
==========================================
- Coverage 81.16% 81.12% -0.04%
==========================================
Files 444 444
Lines 18800 18848 +48
==========================================
+ Hits 15258 15289 +31
- Misses 3542 3559 +17
🚀 New features to boost your workflow:
|
RaviTriv
force-pushed
the
ravtrive/base2-histogram-config-validation
branch
from
July 16, 2026 10:56
e193ae0 to
9c689b9
Compare
RaviTriv
marked this pull request as ready for review
July 16, 2026 12:43
dbarker
reviewed
Jul 16, 2026
dbarker
reviewed
Jul 16, 2026
dbarker
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Please see a few minor comments.
|
|
RaviTriv
force-pushed
the
ravtrive/base2-histogram-config-validation
branch
from
July 17, 2026 00:09
b2bd516 to
72a0769
Compare
RaviTriv
force-pushed
the
ravtrive/base2-histogram-config-validation
branch
from
July 17, 2026 00:15
72a0769 to
4f99033
Compare
dbarker
approved these changes
Jul 17, 2026
dbarker
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Please see a non blocking comment below.
marcalff
reviewed
Jul 18, 2026
marcalff
left a comment
Member
There was a problem hiding this comment.
LGTM, but please add a breaking change section in the changelog.
| } | ||
|
|
||
| size_t max_buckets_ = 160; | ||
| size_t max_size_ = 160; |
Member
There was a problem hiding this comment.
This is a visible change in the SDK configuration interface.
Please add a "breaking change" section in the CHANGELOG, to say max_buckets_ was renamed to max_size_.
ayush-that
pushed a commit
to ayush-that/opentelemetry-cpp
that referenced
this pull request
Jul 21, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4250
Changes
Validates the Base2 Exponential Histogram Aggregation parameters to align with the OTEL configuration spec.
Naming and Types
Base2ExponentialHistogramAggregationConfig::max_buckets_tomax_size_Base2ExponentialBucketHistogramAggregationConfiguration::max_scaletype toint32DocumentNode::GetSignedIntegerto handle negative valuesValidation
InvalidSchemaExceptionif config value is out of range.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes