Skip to content

[CODE HEALTH] Add missing include in aggregation_config.h - #4567

Merged
marcalff merged 4 commits into
open-telemetry:mainfrom
brechtsanders:patch-1
Sep 17, 2026
Merged

[CODE HEALTH] Add missing include in aggregation_config.h#4567
marcalff merged 4 commits into
open-telemetry:mainfrom
brechtsanders:patch-1

Conversation

@brechtsanders

@brechtsanders brechtsanders commented Sep 14, 2026 •
edited by marcalff
Loading

Copy link
Copy Markdown
Contributor

fix undefined int32_t in sdk/include/opentelemetry/sdk/metrics/aggregation/aggregation_config.h (version >= 1.21.0)

Fixes #4565

@brechtsanders
Update aggregation_config.h
46d5e28 
fix undefined int32_t in sdk/include/opentelemetry/sdk/metrics/aggregation/aggregation_config.h (version >= 1.21.0)
@brechtsanders
brechtsanders requested a review from a team as a code owner September 14, 2026 06:16
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.52%. Comparing base (a3f652f) to head (36bb097).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4567      +/-   ##
==========================================
+ Coverage   86.51%   86.52%   +0.01%     
==========================================
  Files         525      525              
  Lines       20464    20464              
==========================================
+ Hits        17702    17704       +2     
+ Misses       2762     2760       -2
Files with missing lines Coverage Δ
...metry/sdk/metrics/aggregation/aggregation_config.h 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff

marcalff commented Sep 14, 2026

Copy link
Copy Markdown
Member

@brechtsanders

Thanks for the fix.

Please sign the CLA so this can be merged.

@owent owent mentioned this pull request Sep 15, 2026
Closed
@dbarker dbarker removed the pr:waiting-on-cla Waiting on CLA label Sep 16, 2026
marcalff
marcalff approved these changes Sep 17, 2026
View reviewed changes

@marcalff marcalff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Update aggregation_config.h [CODE HEALTH] Add missing include in aggregation_config.h Sep 17, 2026
@marcalff
marcalff merged commit 044b114 into open-telemetry:main Sep 17, 2026
77 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 22, 2026
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owent owent owent approved these changes
@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

int32_t / uint8_t not defined when using recent GCC because cstdint is not included

4 participants

@brechtsanders @marcalff @owent @dbarker