Repository navigation
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-09 22:27 UTC Review the latest changes. Also blocked by: Merge conflicts. Status above doesn't look right?
|
There was a problem hiding this comment.
🟡 Changes recommended
All three gRPC factories let tls.insecure=False override explicit HTTP endpoints, breaking plaintext connections.
1 open finding
What changed in this PR
Adds declarative TLS/mTLS configuration for OTLP trace, metric, and log exporters, addressing #5670.
Changes:
- Forwards HTTP certificate paths and builds gRPC credentials.
- Adds shared TLS validation and file-reading helpers.
- Adds TLS tests and a changelog entry.
| File | Description |
|---|---|
| opentelemetry-configuration/tests/test_tracer_provider.py | Tests trace exporter TLS settings. |
| opentelemetry-configuration/tests/test_meter_provider.py | Tests metric exporter TLS settings. |
| opentelemetry-configuration/tests/test_logger_provider.py | Tests log exporter TLS settings. |
| opentelemetry-configuration/tests/test_common.py | Tests validation and credential helpers. |
| opentelemetry-configuration/src/opentelemetry/configuration/_tracer_provider.py | Wires TLS into trace exporters. |
| opentelemetry-configuration/src/opentelemetry/configuration/_meter_provider.py | Wires TLS into metric exporters. |
| opentelemetry-configuration/src/opentelemetry/configuration/_logger_provider.py | Wires TLS into log exporters. |
| opentelemetry-configuration/src/opentelemetry/configuration/_common.py | Adds shared TLS helpers. |
| .changelog/5781.added | Announces declarative TLS/mTLS support. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This comment has been minimized.
This comment has been minimized.
|
/dashboard route:reviewers |
|
@herin049, this pull request was routed to reviewers. The handoff remains active across pushes until newer actionable human feedback arrives. Top-level feedback through this request will not return; unresolved review threads remain open. |

Description
Adds support for configuring TLS/mTLS in
opentelemetry-configurationfor gRPC/HTTP exporters.Fixes #5670
Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
tox -e precommittox -e typecheck