Skip to content

docs: document public API check workaround for patch releases - #5867

Open
mkoltsov wants to merge 3 commits into
open-telemetry:mainfrom
mkoltsov:docs/patch-release-public-api-check-5139
Open

mkoltsov wants to merge 3 commits into
open-telemetry:mainfrom
mkoltsov:docs/patch-release-public-api-check-5139

Conversation

@mkoltsov

@mkoltsov mkoltsov commented Oct 31, 2026 •

Copy link
Copy Markdown

Description

Fixes #5139, documentation update to make it look consistent.

Type of change

  • This change requires a documentation update

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • I am a human and not a bot
  • I have run tox -e precommit
  • I have run tox -e typecheck

@mkoltsov
mkoltsov requested a review from a team as a code owner October 31, 2026 04:22
@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: mkoltsov / name: mkoltsov (7de4c0a)

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-11-08 20:23 UTC

Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):

  • Top-level threads: 1
Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
  • Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

@chiragjangiir chiragjangiir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: docs: document public API check workaround for patches

1. Purpose

Documents the workflow and flag requirements for developers submitting patch releases or internal refactoring PRs where strict public API compatibility checkers (such as check_api.py) trigger false-positive warnings on allowed internal modifications.

2. Documentation Clarity

  • Clear markdown step-by-step instructions with code blocks.
  • Clarifies the deprecation policy and when an API modification actually requires an enhancement proposal vs. a documentation tag.

Helpful documentation update for open-source contributors.

@chrikrah chrikrah left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing here blocks a merge. I checked each claim against the workflow, and all three hold: the script diffs main against the head, the label skips the job, and adding a label doesn't trigger a new CI run.

The other item in #5139, contrib tox environments coming from main, already has its note under contrib.yml on the base commit, so Fixes #5139 closes the whole issue.

$ git show c559a20:scripts/public_symbols_checker.py | grep -n 'commit("main")'
26:    for diff_lines in repo.commit("main").diff(repo.head.commit).iter_change_type(change_type):
$ git show c559a20:.github/workflows/misc.yml | sed -n 253,255p
    if: |
      !contains(github.event.pull_request.labels.*.name, 'Approve Public API check')
      && github.actor != 'otelbot[bot]' && github.event_name == 'pull_request'
$ git show c559a20:.github/workflows/ci.yml | sed -n 6,11p      # misc.yml is workflow_call from here
on:
  push:
    branches:
    - 'main'
  pull_request:
  merge_group:
$ git show 3462000:RELEASING.md | grep -n 'Note on `contrib.yml`'      # base of this PR
42:### Note on `contrib.yml` Workflow Behavior

Approving on that basis.

@herin049 herin049 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 8, 2026

@herin049 herin049 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changelog entry, it's not needed for docs-only changes.

@github-project-automation github-project-automation Bot moved this to Approved PRs in Python PR digest Nov 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Approved PRs

Development

Successfully merging this pull request may close these issues.

Issues when releasting patch releases

4 participants