Conversation
Signed-off-by: Handrey Cunha <handrey.cunha@gmail.com>
Signed-off-by: Handrey Cunha <handrey.cunha@gmail.com>
✅ Deploy Preview for openworkflow-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Handrey Cunha <handrey.cunha@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Root variant cleanup, function-call editing, sentinel restoration, and safe path traversal contain blocking defects.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Open (5)
What changed in this PR
Adds schema-driven field support for call-task forms, including variant switching, discriminator persistence, structured values, MCP controls, and regression coverage.
Changes:
- Expands schema-to-form mapping and custom controls.
- Improves variant state, reset, and dirty tracking.
- Adds unit, integration, and end-to-end tests.
| File | Description |
|---|---|
.changeset/callTask-form.md |
Records the minor feature release. |
tests/test-utils/render-helpers.tsx |
Adds reusable form spying helpers. |
tests/test-utils/index.ts |
Exports added test utilities. |
tests/test-utils/edit-helpers.ts |
Formats editing helpers. |
tests/side-panel/forms/padRemovedPaths.test.ts |
Tests reset-value padding. |
tests/side-panel/forms/customFields/TaskListDisplay.test.tsx |
Tests task-list rendering. |
tests/side-panel/forms/customFields/StringListField.test.tsx |
Tests string-list behavior. |
tests/side-panel/forms/customFields/StringControl.test.tsx |
Extends variant/reset regressions. |
tests/side-panel/forms/customFields/McpProtocolVersionField.test.tsx |
Tests MCP version input. |
tests/side-panel/EditFormFooter.emitTask.test.tsx |
Updates emit-task reset tests. |
tests/side-panel/EditFormFooter.dirtyCounter.test.tsx |
Tests phantom dirty counts. |
tests/side-panel/EditFormFooter.callHttpEndpoint.test.tsx |
Tests call variant persistence. |
tests/core/taskDraft.test.ts |
Tests discriminator writes. |
tests/core/schemaToFormFields.test.ts |
Expands schema-walker coverage. |
tests-e2e/expression-clear-apply.spec.ts |
Covers expression clearing end-to-end. |
src/side-panel/SidePanel.css |
Styles task and string lists. |
src/side-panel/forms/TaskForm.tsx |
Pads removed values during resets. |
src/side-panel/forms/FormField.tsx |
Preserves one-of selections. |
src/side-panel/forms/FieldControl.tsx |
Dispatches new controls. |
src/side-panel/forms/customFields/TaskListDisplay.tsx |
Adds task-list presentation. |
src/side-panel/forms/customFields/StringListField.tsx |
Adds editable string arrays. |
src/side-panel/forms/customFields/StringControl.tsx |
Handles cross-variant stale values. |
src/side-panel/forms/customFields/McpProtocolVersionField.tsx |
Adds MCP version input. |
src/side-panel/forms/customFields/index.ts |
Exports new controls. |
src/side-panel/forms/customFields/DurationField.tsx |
Avoids object stringification. |
src/side-panel/forms/customFields/ChildTaskListField.tsx |
Reuses task-list display. |
src/side-panel/EditFormFooter.tsx |
Applies discriminator writes and reset state. |
src/i18n/locales/en.ts |
Adds control translations. |
src/core/taskDraft.ts |
Applies selected variant constants. |
src/core/schemaToFormFields.ts |
Extends schema-to-field generation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Handrey Cunha <handrey.cunha@gmail.com>
Signed-off-by: Handrey Cunha <handrey.cunha@gmail.com>
handreyrc
requested review from
fantonangeli,
kumaradityaraj and
lornakelly
September 25, 2026 16:42
Signed-off-by: Handrey Cunha <handrey.cunha@gmail.com>
🦋 Changeset detectedLatest commit: c22b193 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #399
This PR introduces full field support to
callTaskform generation in both read-only and edit mode.Not Addressed in This PR
Changes
callTaskform generation, covering HTTP, MCP, OpenAPI, and AsyncAPI call types with appropriate variants and controls.StringListFieldfor string array arguments (e.g. MCP stdio transport arguments).McpProtocolVersionFieldfor MCP calendar-date protocol versions.oneOfdiscriminator patterns and base-property injection alongside variant-specific properties.constWritesto automatically write and keep const discriminator properties (e.g.call: "http") in sync with variant selection.payload,body,data, andasin output/export) toStructuredValueField(JSON/YAML textarea) instead of plain key-value editors or strings.How to Test
callTaskin both read-only and edit mode.