Repository navigation
Close HTTP responses when error handling throws - #746
Closed
fallintoplace wants to merge 1 commit into
Closed
fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
marked this pull request as ready for review
May 19, 2026 18:17
Willsonsors
approved these changes
May 19, 2026
Contributor
sylvesterkaczmarek
added a commit
to sylvesterkaczmarek/openai-java
that referenced
this pull request
Sep 29, 2026
Non-2xx responses bypass the service-level cleanup when the shared error handler throws. Close those responses inside the handler while leaving successful responses open for their callers. Preserve existing exception types, status codes, headers, and parsed error details; failures during cleanup remain suppressed on the original exception. Combines the cleanup implementation from openai#746 and openai#879, openai#746's real error-body parsing and exception-detail assertions, and openai#879's coverage across every exception branch. Additional tests cover status boundaries, malformed JSON, and failures in both parsing and cleanup. Thanks to @fallintoplace and @sylvesterkaczmarek for the original fixes. Both contributors are credited in the commit. This maintainer-owned replacement consolidates their work; the original PRs remain open pending review. Related issue: openai#745. Keep the issue open until a release containing the fix is available. Validation: `:openai-java-core:lintKotlin` and `:openai-java-core:test --tests com.openai.core.handlers.ErrorHandlerTest --tests com.openai.services.ErrorHandlingTest` passed with JDK 21: 37 tests, zero failures (20 new handler cases and 17 existing service cases). `git diff --check` also passed. The full test suite was not run. Co-authored-by: Minh Vu <vuhoangminh97@gmail.com> Co-authored-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpResponseinstances insideerrorHandlerbefore throwing typed service exceptionsFixes #745.
Test plan
JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ./gradlew :openai-java-core:formatJAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ./gradlew :openai-java-core:test --tests com.openai.core.handlers.ErrorHandlerTestJAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ./gradlew :openai-java-core:lintJAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ./gradlew :openai-java-core:test --tests com.openai.services.ErrorHandlingTest