Repository navigation
fix: ignore errors in isinstance() calls on LazyProxy subclasses - #2343
Merged
RobertCraigie merged 1 commit intoMay 7, 2025
Merged
Conversation
RobertCraigie
marked this pull request as ready for review
May 7, 2025 16:42
Contributor
|
Thanks! Not sure why CI isn't running... |
browniebroke
force-pushed
the
isinstance-missing-dep-error
branch
from
May 7, 2025 17:21
bc07fd3 to
7484400
Compare
… on LazyProxy subclasses Fix openai#2056
browniebroke
force-pushed
the
isinstance-missing-dep-error
branch
from
May 7, 2025 17:22
7484400 to
b519b4d
Compare
Contributor
Author
They ran on my fork I think: https://github.com/browniebroke/openai-python/actions/runs/14889434465 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2056
Changes being requested
Additional context & links
I assume this might need to be upstreamed in Stainless then?