Repository navigation
Document the signature methods: PLAINTEXT over HTTPS - #672
Merged
hxdimpf merged 1 commit intoOct 20, 2026
Merged
Conversation
…o timestamp/nonce checks over HTTPS)
This was referenced Oct 20, 2026
hxdimpf
added a commit
that referenced
this pull request
Nov 2, 2026
Entries in `etc/changes.xml` for the changes merged since the last changelog PR (#665) that matter to client developers or site admins: #649, #654, #646, #651, #682, #680, #666, #676, #672, #671, #667. Version numbers and times were filled in by `etc/update_changes.php`. #652 has no visible change for clients, so it has no entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #475.
Since 2017 (195bcb8, a73ba55), OKAPI accepts PLAINTEXT signatures over HTTPS and skips the timestamp and nonce checks there. Clients use this, but the documentation still says that OKAPI requires HMAC-SHA1. @wrygiel pointed this out in #663.
The introduction page gets a short section "Signature methods":
The error list for
unsupported_signature_methodlinks to that section instead of saying "requires HMAC-SHA1".No code change. Checked against the code (
OkapiOAuthServer,OAuthServer::get_signature_methodandcheck_signature) and on opencaching.de:oauth_timestampandoauth_nonceis accepted;The page renders on my test installation.