Chore adjust swagger for api gateway - #33694
Conversation
| @@ -347,6 +347,6 @@ | |||
| # Custom settings are provided in SPECTACULAR_SETTINGS in cms/envs/common.py. | |||
There was a problem hiding this comment.
| # Custom settings are provided in SPECTACULAR_SETTINGS in cms/envs/common.py. | |
| # Custom settings are provided in SPECTACULAR_SETTINGS as environment variables |
Also, I know that this is not your doing, but the fact that SPECTACULAR_SETTINGS have to be defined as env variables and can't be overwritten per API is kind of frustrating no?
There was a problem hiding this comment.
It is. I'm hoping there is a solution somewhere in spectacular for it, so that we can keep our separate swagger ui for the cms api later on after we switch to spectacular completely.
connorhaugh
left a comment
There was a problem hiding this comment.
Looks good, just a nit and also you have some lint issues
Co-authored-by: connorhaugh <49422820+connorhaugh@users.noreply.github.com>
…er-for-api-gateway
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
How to test:
Necessary to dos:
Depends on these PRs, please review as well:
https://github.com/edx/edge-internal/pull/626
https://github.com/edx/edx-internal/pull/9636