Codex/mobile live favorites - #624
Open
zirocool93 wants to merge 3 commits into
Open
zirocool93 wants to merge 3 commits into
zirocool93 wants to merge 3 commits into
Conversation
Contributor
|
Thank you for your contribution to lightNVR! 🎉 Before we can merge your pull request, we need you to sign our Contributor License Agreement (CLA). Why a CLA? To sign the CLA, please reply to this comment with exactly: You only need to sign once, and it applies to all future contributions. ℹ️ More about the CLAThe CLA grants OpenSensor Engineering the right to:
You retain copyright of your contributions and can use them in other projects. |
matteius
added a commit
that referenced
this pull request
Oct 5, 2026
WebRTCVideoCell awaits the go2rtc base URL, the timeout settings and the ICE server list before creating its RTCPeerConnection, with no abort check in between. When a tile unmounts during those awaits (page change, layout switch, navigating away) the unmount cleanup has already run, so the connection created afterwards is never closed and leaks along with its ICE candidates and media tracks. Check the cell's abort signal after each await, pass it to the ICE servers fetch, and close a connection that turns out to be stale in the setup catch path. Found by zirocool93 under a browser stress test (80 cameras, 20 pages, delayed ICE) and extracted from #624. Co-authored-by: zirocool93 <zirocool93@users.noreply.github.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.