Skip to content

Missing changes from onyx review #4441 - #4446

Merged
dtrawins merged 3 commits into
mainfrom
przepeck/onyx_fixes
Aug 12, 2026
Merged

dtrawins merged 3 commits into
mainfrom
przepeck/onyx_fixes

Conversation

@przepeck

@przepeck przepeck commented Aug 12, 2026 •

Copy link
Copy Markdown
Collaborator

🛠 Summary

Missing changes from review #4441

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies follow-up tweaks to the Onyx LLM output parsing path, aligning it with shared helper utilities and cleaning up stale commentary, as part of completing the review feedback from #4441.

Changes:

  • Replaced manual boolean lowercasing with the shared normalizeBooleanString() helper in the Onyx tool parser.
  • Removed outdated TODO commentary from the Onyx reasoning streaming parser.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/llm/io_processing/onyx/onyx_tool_parser.cpp Uses shared boolean normalization helper before RapidJSON parsing for schema-typed boolean parameters.
src/llm/io_processing/onyx/onyx_reasoning_parser.cpp Removes outdated TODO comments in streaming chunk parsing logic without changing behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@przepeck przepeck changed the title Missing changes from review #4441 Missing changes from onyx review #4441 Aug 12, 2026
@dtrawins
dtrawins merged commit 103456a into main Aug 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants