Conversation
There was a problem hiding this comment.
These should be alphabetized just like how you did in help_controller.rb
| @@ -0,0 +1,3 @@ | |||
| <h4><%= t(".page_heading") %></h4> | |||
There was a problem hiding this comment.
Generally the new files are meant to look just like the old ones, even if that means they'll be inconsistent. If it helps, I think this one has no heading because it's just one paragraph.
ASalbenblatt
left a comment
There was a problem hiding this comment.
Looks good, thanks :)
Bilka2
left a comment
There was a problem hiding this comment.
Thank you for working on this, I have only one small thing: The help titles should generally match exactly what is currently used, so I've left suggestions for that
| no_challenge: No Challenge | ||
| prompt_meme: Prompt Meme Challenge | ||
| form: | ||
| collections_name_help_title: Collection name help |
There was a problem hiding this comment.
| collections_name_help_title: Collection name help | |
| collections_name_help_title: Collection name |
To match the current help title
| label: Custom header URL | ||
| icon: | ||
| delete: Delete collection icon and revert to our default. This will also remove the icon alt text and comment text. | ||
| icon_alt_text_help_title: Icon alt text help |
There was a problem hiding this comment.
| icon_alt_text_help_title: Icon alt text help | |
| icon_alt_text_help_title: Icon alt text |
To match the current help title
| icon_alt_text_help_title: Icon alt text help | ||
| icon_comment: Icon comment text | ||
| icon_comment_text_help_title: Icon comment text help |
There was a problem hiding this comment.
| icon_alt_text_help_title: Icon alt text help | |
| icon_comment: Icon comment text | |
| icon_comment_text_help_title: Icon comment text help | |
| icon_alt_text_help_title: Icon alt text | |
| icon_comment: Icon comment text | |
| icon_comment_text_help_title: Pseud icon comment |
To match the current help title
| icon: | ||
| delete: Delete collection icon and revert to our default. This will also remove the icon alt text and comment text. | ||
| icon_alt_text_help_title: Icon alt text help | ||
| icon_comment_text_help_title: Icon comment text help |
There was a problem hiding this comment.
| icon_comment_text_help_title: Icon comment text help | |
| icon_comment_text_help_title: Icon comment text |
for consistency
There was a problem hiding this comment.
I've updated the locale file!
Bilka2
left a comment
There was a problem hiding this comment.
Thank you both for coding and reviewing!
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7515
Purpose
Move help HTML files
pseud-icon-comment.html,icon-alt-text.html, andcollection-name.htmlto HTML erb filesicon_comment_text.html.erb,icon_alt_text.html.erb, andcollections_name.html.erb. Also updatelink_to_helpfor these modals tolink_to_help_modal, and add redirects toroutes.rb.Credit
zrei (she/they)