Conversation
Bilka2
force-pushed
the
AO3-7600-refactor-inbox-comment
branch
from
September 11, 2026 15:13
c980a15 to
e345fd4
Compare
Bilka2
commented
Sep 11, 2026
sarken
reviewed
Sep 21, 2026
sarken
left a comment
Collaborator
There was a problem hiding this comment.
Not a full review, just an answer to a question and a suggestion!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7600
Purpose
Refactor the includes for inbox_comment.
Additionally, combine the inbox_comment views into one partial. However, I'm not quite sure whether this is beneficial, since I had to keep some conditionals based on where the partial is displayed. I'm happy to revert the commit that does the view changes if we'd rather not combine the views.
References
PR limit does not apply to volunteers with write access to the repository.
Credit
Bilka