Conversation
omerfaruk-pseud
approved these changes
Sep 19, 2026
omerfaruk-pseud
left a comment
Member
There was a problem hiding this comment.
Looks great, but what do you think about catching or outright removing the "Bookmarks is invalid" message (which I'm pretty sure is coming from the inverse relationship between Bookmark(s) and Bookmarkable)
Contributor
Author
|
I'd rather not change error behaviour in an issue/PR about preparing errors for translations, since that's not covered by tests nor accounted for in the issue design |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7603
Purpose
i18n the error messages in the external work model. I didn't add tests for these because it's all standard Rails validations and it's easy to manually test them.
References
PR limit does not apply to volunteers with write access to the repository.
Credit
Bilka