Skip to content

AO3-7606 Replace tag.strong with style_bold - #6029

Open
rosarette wants to merge 1 commit into
otwcode:masterfrom
rosarette:AO3-7606_fix-mailer-bold
Open

rosarette wants to merge 1 commit into
otwcode:masterfrom
rosarette:AO3-7606_fix-mailer-bold

Conversation

@rosarette

@rosarette rosarette commented Sep 14, 2026 •

Copy link
Copy Markdown

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7606
I don't have access to the Jira Board yet!

Purpose

What does this PR do?
Changed tag.strong to style_bold in admin_deleted_work_notification.html.erb to match the i18n standard for mailing as requested

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

You can remove this section if there are already full testing instructions in the Jira issue.

Visit http://localhost:3000/rails/mailers, under User Mailer click on admin_deleted_work_notification and check there!

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

rosarette (she/her) is fine! sorry if i made any mistakes here btw, i havent used git before
My Jira account should be under the same name "rosarette"

@sarken sarken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, rosarette!

Thank you so much for this pull request. The change looks good to me, so if the tests finish running successfully, I'll mark this approved!

In the meantime, I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request.

Jira has been unreliable about showing us new accounts in the admin panel, and I unfortunately can't find yours to update your permissions. If you could either reply here or send an email to otw-coders@transformativeworks.org with your account's email address, we should be able to fix that and get you set up.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants