Skip to content

PFE-Dropdown has incorrect aria and a11y setup #2054

Closed
Closed
PFE-Dropdown has incorrect aria and a11y setup#2054
Labels
RHDSaccessibilityImprove accessibilitypriority: mediumSeverity level: 2

Description

@wesruv
wesruv
opened on Jul 1, 2022

Description of the issue

This was noticed on PFE 1.x, but I suspect it might also be in 2.x, full discussion is here: https://chat.google.com/room/AAAA0siaVdA/V0r-JRHGmOY

It should follow the aria/accessibility setup from: https://pattern-library.dequelabs.com/components/selects

Basically it should be following the listbox pattern, instead of a menu, menu has very specific expectations similar to the "File" menu in applications:

While the term "menu" is generically used a term used to describe site navigation, the menu role is for a list of action or functions that require complex functionality, such as composite widget focus management and first-character navigation
From: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role

Impacted component(s)

  • pfe-dropdown

Activity

  1. wesruv
    added
    accessibilityImprove accessibility
    priority: mediumSeverity level: 2
    RHDS
    on Jul 1, 2022

  2. wesruv commented on Jul 1, 2022

    @wesruv
    wesruv
    on Jul 1, 2022
    ContributorAuthor

    I don't see this component in RHDS yet, adding the tag because I'm guessing it might be headed there?

  3. bennypowers commented on Jul 8, 2022

    @bennypowers
    bennypowers
    on Jul 8, 2022
    Member

    The next step for pfe-dropdown will be to align it with PFv4. We could address this during that process. Is it the case that you will want dropdown in RHDS, being the successor to pfe 1.x dropdown? in that case please fill out a request for new component there.

  4. wesruv commented on Jul 8, 2022

    @wesruv
    wesruv
    on Jul 8, 2022
    ContributorAuthor

    Cool, I think it'd be great to have this in RHDS, I'd guess @kylebuch8 && @TylerMartin5 would also be interested. Made a ticket: RedHat-UX/red-hat-design-system#425

  5. bennypowers commented on Jul 17, 2022

    @bennypowers
    bennypowers
    on Jul 17, 2022
    Member

    See also #2049

  6. bennypowers commented on Mar 20, 2025

    @bennypowers
    bennypowers
    on Mar 20, 2025
    Member

    Closing, as we have <pf-select> now.

  7. bennypowers
    closed this as completedon Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    RHDSaccessibilityImprove accessibilitypriority: mediumSeverity level: 2

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions