Skip to content

[bug] pf-button slotted svg broken docs or missing API? #2403

Closed
#2398
Closed
[bug] pf-button slotted svg broken docs or missing API?#2403
#2398
Assignees
bennypowers
Labels
bugpriority: lowSeverity level: 3

Description

@zeroedin
zeroedin
opened on Mar 3, 2023

Description of the issue

image

The first pf-button link variant should display a slotted svg by the docs. However, the slot API for this does not exist. Is this broken docs or broken button API?

 * @slot icon
 *       Contains the button's icon or state indicator, e.g. a spinner.

https://patternflyelements.com/components/button/

Activity

  1. zeroedin
    added
    priority: lowSeverity level: 3
    bug
    on Mar 3, 2023
  2. zeroedin
    assigned
    bennypowers
    on Mar 3, 2023

  3. zeroedin commented on Mar 3, 2023

    @zeroedin
    zeroedin
    on Mar 3, 2023
    CollaboratorAuthor

    Figured it out with other examples. The slot="icon" is no longer part of the API. The docs should reflect that. Removing the @slot icon from jsdoc.

  4. zeroedin
    closed this as completedon Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugpriority: lowSeverity level: 3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions