Repository navigation
Bug - NavItem - Icons don't show if there are complex children #11092
Description
Describe the problem
The NavItem lets you show an icon. However, this breaks if you pass in a child with a div.
How do you reproduce the problem?
If you give any NavItem a child that's wrapped in a div, the icon won't show: https://codesandbox.io/p/sandbox/agitated-babycat-rvrw7v?file=%2Findex.tsx%3A32%2C21&workspaceId=f5599198-6a68-44b3-85bd-1caed5609909
If you remove the div, the icon comes back.
Expected behavior
Icon should display consistently.
Is this issue blocking you?
No!
Activity
github-actions commentedon Jan 7, 2025
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
thatblindgeye commentedon Feb 6, 2025
This looks to be expected behavior when passing custom content like this. At the very least we should update documentation to make this clearer, with the possibility of revisiting this behavior.
thatblindgeye commentedon Feb 10, 2025
Will close this out as expected behavior. If others start bringing this up we can revisit this, though.