Repository navigation
chore: remove stale notebooks/scripts, unlinked and years out of sync - #51
Merged
Merged
Conversation
notebooks/scripts/*.py was a one-off jupytext (py:light) snapshot of the chapter notebooks from April 2022 (confirmed by regenerating the April-2022 notebook with jupytext and diffing against the committed file at that same commit -- near-exact match, unlike plain `jupyter nbconvert --to python`, which adds shebang/coding headers and `# In[ ]:` markers this file never had). Only 4 of the 16 files were ever regenerated since (Jan 2023, "regenerated from book LaTeX source"); the rest, including chap2.py, have been frozen since the original commit while their source notebooks kept receiving fixes -- e.g. the framelabel/frame typo just fixed in the chap2 notebook was still present here. Nothing in the repo links to or documents this folder -- the README's own "Convert to Python script" section already documents the manual `jupyter nbconvert --to python` command as the way to get a .py copy of a notebook, independent of whether one is pre-generated and committed. Removing the stale, undiscoverable copies rather than adding CI/bot machinery to keep them in sync: this repo is book-companion content with a light maintenance model, not worth the ongoing ceremony of a drift-check (needs a pinned jupytext dev-dependency and a required regenerate-before-commit step) or an auto-commit bot (can't actually work for external-contributor PRs, since GitHub Actions' default token has no write access to a fork's branch; removes the one human-review checkpoint on the generated diff even for direct pushes). Also removes notebooks/Makefile, which only ever supported the reverse direction (.py -> .ipynb via jupytext) and has no remaining purpose once the .py files it consumed are gone. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notebooks/scripts/*.pywas a one-offjupytext(py:light) export of the chapter notebooks from April 2022. Confirmed by regenerating the exact April-2022 notebook withjupytextand diffing against what was committed in that same commit — a near-exact structural match (unlike plainjupyter nbconvert --to python, which adds a shebang/coding header and# In[ ]:markers that these files never had).chap2.py— have been frozen since the original commit while their source notebooks kept receiving fixes. Concretely: theframelabel/frametypo just fixed inchap2.ipynb(Fix frame labels in chapter 2 notebook #50) was still present inchap2.py.notebooks/README.md's own "Convert to Python script" section already documents the manualjupyter nbconvert --to pythoncommand as the way to get a.pycopy of a notebook, independent of whether one is pre-generated and committed.jupytextdev-dependency (output format is version-sensitive — confirmed empirically) plus a required regenerate-before-commit step for every notebook edit, code or markdown;notebooks/Makefile, which only ever supported the reverse direction (.py→.ipynbviajupytext) and has no remaining purpose once the.pyfiles it consumed are gone.Test plan
Makefile) for any reference tonotebooks/scriptsornotebooks/Makefile— none foundtests/for any reference to the removed files — none foundnbformat, missingroboticstoolbox-pythonpackage metadata in this dev env), confirmed by reproducing them directly outside this change🤖 Generated with Claude Code