Conversation
A raw UTF-8 path crashed on ascii decode before the app ran. Paths now decode as UTF-8, with latin-1 for bytes that are not UTF-8. QUERY_STRING uses latin-1 so the WSGI bytes round-trip.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request path with raw UTF-8 bytes, such as
/café, crashed inpath.decode("ascii")before the app ran. Percent-encoded UTF-8 already worked.decode_pathuses UTF-8, then latin-1 when the bytes are not UTF-8. WSGIQUERY_STRINGis decoded as latin-1, which is the PEP 3333 native-string encoding, so a non-ASCII query no longer raises either.