Repository navigation
docs: LIMITS, THREAT-MODEL, SECURITY and roadmap match the code (C4.4, CORE-177) - #419
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
🛡️ pharn-ci · ✅ PassTip Pass · This change adds no coverable lines; 29 agent setup files found.
🧪 Diff coverageNo coverable lines changed. 🔍 Test integrityNo test-integrity findings (mode: block). 💬 Messages (1)
🤖 Agent setup (29 files)Agent setup: 29 files · claude-code Agent setup files (29)
pharn-ci 0.10.0 · report schema v2 · coverage format lcov |
…ut, uninstall (C4.4, CORE-177) SECURITY.md: the verified release is the default channel and `main` the opt-in; everything installs under pharn/ and .claude/ (pharn/.lock, pharn/.backup/); the capability index comes from pharn-install.json, not frontmatter; every fetch is fetchCapped with a withDeadline hard deadline; a record key becomes a path only for orphan reads and uninstall. docs/roadmap.md: add the `pharn uninstall` and `--ref` rows; the lock and backup rows name uninstall (and init); the TTY row matches init/update/ uninstall --yes; the update row follows the recorded channel. THREAT-MODEL.md and LIMITS.md follow via the human-applied patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…line, 24.2 floor (C4.4, CORE-177) THREAT-MODEL.md: the verified release is the default channel; every fetch is fetchCapped with the withDeadline hard deadline; the proxy text follows the 24.2.0 floor; the table names the release resolve; §3.1 drops `modules`; §4c cites functions instead of line numbers. LIMITS.md: §1a pharn-install.json + isPharnOwnedPath, files in pharn/ and .claude/; §1b/§3a the release resolve is the default; §1c archetypes and capabilities; §1d names instead of line numbers; §3a the 24.2.0 floor's proxy opt-in; §3e the structural break is an unreadable pharn-install.json. Applied by a maintainer from the reviewed patch script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PrzemekGalarowicz
force-pushed
the
przemek/core-177-guarantee-docs
branch
from
November 17, 2026 12:42
5ed80ef to
76a1814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of epic CORE-153 (C4). Docs only, no CLI output change, so no CHANGELOG line.
This PR carries
SECURITY.mdanddocs/roadmap.md.THREAT-MODEL.mdandLIMITS.mdare human-owned and hook-protected, so their changes are in a patch script (patch-core-177.py) that a maintainer runs. It will be committed into this PR afterwards. The script applies cleanly on top oforigin/mainin either order with C4.2'spatch-core-175.py, because the two never edit the same text.Checklist (ticket items)
x"skipped": already fixed onmain(§2 listsxunder REJECT). Nothing to do.finally: (patch) every fetch now goes throughfetchCapped(src/lib/fetch-capped.ts) with thewithDeadlinehard deadline (src/lib/deadline.ts, aPromise.race). The §3 table names the release resolve andfetchCapped.add/status, which still run below the floor (onlyinit/updaterefuse there).mainchannel … opt-in--ref latest": the verified release is now the default.mainis the opt-in, along with its degraded mode..pharn.lock/.pharn-backup/: everything installs underpharn/and.claude/(named in full). The lock and backups arepharn/.lockandpharn/.backup/<timestamp>/. The license goes only topharn/LICENSE, and the appended.gitignore/.prettierignorelines are listed.@mainframed as the default (§2 item 6, §4c): (patch) these now say "the install's channel: the newest verified release by default, or@main". The "One resolve" bullet and the fetch-boundary lead name the release resolve first.mainchannel, the branch head)". §1b:commitis the release tag's commit by default, and best-effort only onmain.module.json/INSTALL_PATH_RE: (patch) replaced withpharn-install.jsonand the backstopisPharnOwnedPath+safeJoin+ destination symlink walk..claude/: (patch) nowpharn/and.claude/.modules[]/installedSkills[]: (patch) nowarchetypes/capabilities. "module X" becomes "capability X".patch-core-175.py, which rewrites that exact sentence. This patch leaves it alone so the two cannot conflict. It also leaves the C4.2-owned "updatenever deletes" sentence (LIMITS.md:72) alone.pharn uninstallrow: added.uninstall.init,add,removeanduninstall.init/update": rewritten. Every prompt exits 1 off a TTY,update --yes/uninstall --yesskip the confirm, andinit --yeskeeps its own row.updaterow ignores channels, no--refrow: theupdaterow follows the recorded channel, and a--ref latest|mainrow was added.file.ts:linecitations become module/function names: (patch) THREAT-MODEL §4c (decideFileActionrows,diffInstalledCapabilities,readDiskState) and LIMITS §1d (mergeCapabilities,deleteCapabilityDir,pruneCapabilityRecords).src/commands/update.ts:452goes in C4.2's patch. Once both patches are applied, none of the four files has a line citation.Found while checking every citation (same files)
pharn-install.jsonand no longer from frontmatter. Its allowlists live insrc/lib/upstream-manifest.ts, notcapability-index.ts. The fail-closed "stamp check" became the recorded-hash check, because the stamp never gates anything. A record key becomes a path only for the orphan read and theuninstalldelete.modules, and pharn never writesseam.pharn-install.json.Capability subtree "…" is missingmessage no longer exists. A structural break is now apharn-install.jsonthis CLI cannot read (readUpstreamManifest). Only an unknownappliestoken is tolerated and reported.Verification
npm run lint:md: 0 issues, run on this branch and on both patched files.src/...path cited in the four files exists. Every backticked identifier is insrc/, except the historicalTAR_ENTRY_INVALID.prettiercovers only TS. The root docs are covered bylint:mdand by theprotect-trusted-pathshook.🤖 Generated with Claude Code