Repository navigation
Conversation
Allow VIEW_TERMINAL to run an explicit process profile in a fresh tab and report its exit code once. Report cancellation before killing the process, retain its output after exit, and exclude process tabs from saved shell names and project restarts. This lets Claude sign-in recovery distinguish a completed login from stored but expired credentials. Keep the Home demo controls visible over an existing conversation and add the localized login-launch error message. Pin Phoenix Pro to 19028ba4921d3ef0abb1891486ea80eb54d9a1be for the matching auth refresh, duplicate-login protection, and separate-chat demo behavior. Add registered terminal integration coverage for successful and failed process exits, cancellation, invalid startup, persistence, and restart. Terminal passes 39/39 and AI Chat CLI passes 56/56 on Windows, macOS, and Linux. Targeted ESLint, whitespace checks, and LESS compilation pass. Real browser-login confirmation and hosted CI remain pending.
Pin Phoenix Pro to 35793ccb64a2e20a6d679cc68733f0bc3ca98cbe. App-upgrade trial and paid-Pro what's-new dialogs now lead with the AI feature; first-time users keep the current Live Preview first flow. The Pro change was manually verified in native Electron, including slide content, captions, arrows, dots, and auto-advance. No test suites were run for this presentational follow-up, as requested.
Use the approved AI slide heading, "Your AI Agents, Now Visual in Phoenix Pro", and describe bringing an existing Claude Code or ChatGPT subscription into Phoenix Code to build and refine websites visually. Keep the text in the existing English localization keys, without the feather emoji. Pin Phoenix Pro to 07c789f0cbab5ed9de9cf91b68b37d61719cb4e7 so upgrade and paid-Pro dialogs present AI, Layers, Live Preview, then Markdown. First-time users retain the existing slide order. The final wording and carousel were reviewed in the connected Linux debug app. Targeted ESLint and whitespace checks pass. No test suites were added or run for this presentational follow-up, as requested.
Hide the close button's left border when the Surprise Me card is expanded. Keep the original divider in the first-time card and preserve button dimensions and behavior. Verified both layouts in the connected Linux app and compiled the LESS stylesheet successfully. No test suites were added or run for this CSS-only change.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix. Phoenix could keep showing Claude's Set up or Sign in action after browser login, and the Home demo link disappeared once a conversation existed. This PR adds the terminal support and UI styles required by the companion Pro fixes, and pins the AI-first upgrade carousel.
35793ccb64a2e20a6d679cc68733f0bc3ca98cbe, which refreshes sign-in on return to Phoenix and before setup, and shows Build and refine with AI first for app upgrades and existing paid Pro users. First-time users retain Live Preview first.Does this PR introduce a breaking change?
No. The terminal process options are additive; existing shell-command behavior is preserved.
Tests done
Other information
Companion: https://github.com/phcode-dev/phoenix-pro/pull/293. The core pin matches that PR's head.
Expected commits on
aiovermain:55c043a7c— track login processes and restore Home demos.bb5ef9bd5— pin Pro upgrade carousel ordering.Suggested changelog: Refresh Claude sign-in after browser login, restore access to Home demos, and introduce AI first in upgrade dialogs while preserving the first-time flow.