Remove the mysqlnd_reverse_api feature - #21409
Merged
Merged
Conversation
kamil-tekiela
force-pushed
the
mysqli_reverse_api
branch
from
April 23, 2026 16:59
1e05c1c to
aebb124
Compare
Member
|
Looks good to me. However, it seems that only one CI job has been triggered, so I’d like to check that all CI jobs pass successfully. |
kamil-tekiela
force-pushed
the
mysqli_reverse_api
branch
from
September 30, 2026 11:49
65ac6d2 to
d24c79d
Compare
SakiTakamachi
approved these changes
Sep 30, 2026
SakiTakamachi
left a comment
Member
There was a problem hiding this comment.
The Windows CI is failing, but given the scope of the changes, I don't think it's related.
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Sep 30, 2026
* upstream/master: (34 commits) Remove the mysqlnd_reverse_api feature (php#21409) ext/intl: Fix grapheme_strstr() and grapheme_stristr() match offsets after supplementary characters (php#24012) pdo: refactor pdo_stmt_construct() to use zend_object* rather than zval* (php#24019) Zend: Skip frameless registration for temporary modules ext/curl/config.m4: include string.h for test using strncmp() ext/soap/tests/bugs/bug62900.phpt: make use of TEST_PHP_ vars sapi/cli/tests/php_cli_server_ipv6_error_message.phpt: use TEST_PHP_ vars Zend/tests: organize some tests with sub directories (11) (php#22731) zend_hrtime: remove zend_hrtime_posix_clock_id (php#24016) Zend/lazy_objects: add const qualifiers Zend: use zend_get_gc_buffer_add_fcc for lazy objects Zend: use uint32_t type for lazy_properties_count reflection: mark reflection_class_new_lazy as static always inline reflection: use ZEND_FCC_INITIALIZED macro for lazy objects Zend/lazy_objects: drop variable which is used once Zend: use zend_object* parameter type instead of zval* for closure API (php#24015) Fix HashTable UAF when rebound from a parameter __toString() Fix phpGH-22051: report errors from SQLite3Result reset and finalize Update IR (php#24013) Fix array_map optimization with non-literal function or non-literal args (php#23254) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit should be merged regardless. The second one is technically removing a feature that puts one line in
phpinfo()but this information is already implied from the extensions that use it. Both mysqli and PDO_MySQL will report that they use mysqlnd so the reverse is redundant.