ext/mysqlnd: Fix memory leak when closing a statement on a killed connection - #21765
Closed
kamil-tekiela wants to merge 1 commit into
Closed
kamil-tekiela wants to merge 1 commit into
kamil-tekiela wants to merge 1 commit into
Conversation
ndossche
reviewed
Apr 16, 2026
ndossche
left a comment
Member
There was a problem hiding this comment.
I'm no longer involved, so can't meaningfully review this without spending time on it.
From a quick look it seems logical but who knows for sure without spending more time on it.
iluuu1994
reviewed
Apr 17, 2026
Member
|
I think this should be testable using fake server. |
kamil-tekiela
marked this pull request as draft
September 24, 2026 15:58
kamil-tekiela
force-pushed
the
Fix-close_on_server
branch
from
September 24, 2026 16:56
744ec05 to
8a011e1
Compare
kamil-tekiela
marked this pull request as ready for review
September 24, 2026 16:56
Member
Author
|
@bukka I have added a test for this which showed that my fix wasn't complete. I rewrote the whole PR and changed the target to PHP 8.4. |
kamil-tekiela
force-pushed
the
Fix-close_on_server
branch
from
September 24, 2026 17:30
8a011e1 to
93a4883
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.